chore: change controller's deploy strategy to RollingUpdate due to leader election #3334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yu-croco <[email protected]>
yu-croco
force-pushed
the
configurable-controller-deploy-strategy
branch
from
c56d3a0
to
0406ff8
Compare
|
yu-croco
changed the title
Go Published Test Results2 097 tests 2 097 ✅ 2m 49s ⏱️ Results for commit 0406ff8. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3334 +/- ##
==========================================
- Coverage 81.79% 81.77% -0.02%
==========================================
Files 135 135
Lines 20649 20649
==========================================
- Hits 16889 16886 -3
- Misses 2885 2888 +3
Partials 875 875 ☔ View full report in Codecov by Sentry. |
yu-croco
changed the title
yu-croco
changed the title
E2E Tests Published Test Results 4 files 4 suites 3h 29m 15s ⏱️ For more details on these failures, see this check. Results for commit 0406ff8. |
zachaller
approved these changes
Jan 28, 2024
6 tasks
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".background
Though there was a constraint to use deployment strategy
Recreatedue to race condition #38, now it seems we don't have to care about deployment strategy as below.https://cloud-native.slack.com/archives/C01U781DW2E/p1640199673233000
argo-helm got the PR that let controller's deployment strategy configurable, so I wonder we can change the default strategy as
RollingUpdate. 🙋